-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wrapping and variable interpolation in help
in the devshell menu
#298
base: main
Are you sure you want to change the base?
Conversation
a5b3234
to
39e5a0d
Compare
modules/commands.nix
Outdated
@@ -178,7 +178,7 @@ in | |||
help = "prints this menu"; | |||
name = "menu"; | |||
command = '' | |||
cat <<'DEVSHELL_MENU' | |||
cat <<${(x: if config.devshell.menu.interpolate then x else "'${x}'") "DEVSHELL_MENU"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd instead change it for everyone or make it configurable on the command level. With flake-parts, commands can get composed from different places, and then it's hard to know how the help is going to be interpolated from the different leafs.
Let's also make the "name" more strict, so it cannot include characters like $
39e5a0d
to
7a9e2df
Compare
help
in the devshell menu
Hmm, what can be the error on macOS? UPD: it was due to longer than |
6fbe1a9
to
d020c6d
Compare
ec94703
to
26a0cfa
Compare
26a0cfa
to
a00e035
Compare
- fix test failing on macos due to directory name wrapping
a00e035
to
c6f33b9
Compare
@zimbatm, @blaggacao, please, review |
Although this is not a moderated repository. Recent Moderation Team actions has scared me away from the Nix Community. I'm sorry, won't be available for review. This has nothing to do with you and your effort which is really commendable. Keep the spirit up! |
Based on #290
Interpolation
There's a
.env
file not added to git.A
devshell
user would like to open the address in a browser.She can write this expression.
And get this devshell menu.
Wrapping
The default devshell looks like this: