Build size analysis #1450
Merged
Build size analysis #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Current failure is most likely due to running from a PR (and therefore not having the proper auth token). Should be OK once merged. |
LeaNumworks
reviewed
Apr 6, 2020
| # ELF analysis | ||
|
|
||
| def loadable_sections(elf_file, address_prefix = ""): | ||
| objdump_section_headers_pattern = re.compile("^\s+\d+\s+(\.[\w\.]+)\s+([0-9a-f]+)\s+([0-9a-f]+)\s+("+address_prefix+"[0-9a-f]+)\s+([0-9a-f]+).*LOAD", flags=re.MULTILINE) |
There was a problem hiding this comment.
Maybe add a comment to explicit this to the reader?
There was a problem hiding this comment.
Well… this is an unfair request 😄 This exact same code already made it to the tree without any comment whatsoever. See build/device/elf2dfu.py 😄
|
It doesn't work well :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to compare the size of two binaries, and hooks it into the CI system to report it on any incoming PR.