-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile time apps modularity, version 2 #227
Conversation
08472c0
to
e1ce417
Compare
I made another sample app (https://github.com/boricj/numworks-tic-tac-toe) to further demonstrate. |
Nice! |
I hope that modularity remains a goal for Numworks, and as such, that this PR is merged ASAP :) |
Hi @boricj . Thank you very much for this PR, which we definitely will merge. I'd like to apologize for not merging it before: it was conflicting with the upcoming Python app and we were on a tight schedule. The biggest conflict is most likely the one from 3bca25c , but maybe simply removing this commit might work. As you can see, we (hopefully) fixed the |
This commit can be regenerated with the following shell snippet: ``` for i in UndefinedValue ForbiddenValue Goto ValueNotReachedByFunction Initialization Trigonometric RoundAbscissa Orthonormal DefaultSetting Axis Zoom GraphTab IntervalSet XStart XEnd Step Plot DisplayValues ActivateDesactivate NoFunctionToDelete Language FunctionOptions ClearColumn ColumnOptions DataTab CopyColumnInList FunctionColumn Move Or ValuesTab Goto ToZoom HardwareTestLaunch1 HardwareTestLaunch2 HardwareTestLaunch3 HardwareTestLaunch4 ActiveExamModeMessage1 ActiveExamModeMessage2 ActiveExamModeMessage3 ExitExamMode1 ExitExamMode2 Sci Rad Deg do move=$(grep "^$i = " -r *) if [ -n "$move" ] then echo "$move" | while read -r item do file=$(echo "$item" | cut -f1 -d:) lang=$(echo "$file" | cut -f2 -d.) translation=$(echo "$item" | sed -e 's/^[^:]*://') label=$(echo "$translation" | sed -e 's/=.*//') sed -i "/^$label/d" "$file" echo "$translation" >> "apps/shared.$lang.i18n" done fi done for i in apps/shared.*.i18n do sort $i -o $i done ```
e1ce417
to
57a864a
Compare
This pull request has been rebased. |
Thank you very much @boricj, that is a very good PR! And thank you for rebasing! |
Nice! And you know what else this is good for? Allowing users to add separately distributed GPL licensed apps to their local build. ;) Especially once the Epsilon license is fixed ( #38 )... |
Second version of #73, along with an updated "Hello, World!" sample at https://github.com/boricj/numworks-hello-world.
The main issue now is that there are lots of translations inside apps that are used in shared files, which is taken care of in
[apps] Extract shared translations from apps
.