-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ion::msleep and LED blinking with Timer + various register definitions #314
Conversation
cb7e381
to
eba5481
Compare
I cleaned up the pull request and switched I won't attempt trying out interrupts without a means to debug the hardware though, so this pull request is done. Power consumption should be identical to the current implementation. |
It looks like a very good PR, thank you @boricj ! It is not a good time right now for us to review and merge it as we are close to release a new update. However, if you could split the the first commit (about the Valgrind uninitialised read) from the others, I will merge it right away. |
aaf404d
to
e8cccc7
Compare
Turns out setting up a timer for |
While messing with timers, I've managed to decouple the exam LED blinking from the event loop and enable LED charging status. Activating exam mode makes the LED blink red and inhibits any LED change until it is deactivated. A side-effect is that the LED will now keep blinking in exam mode while the calculator is shut down or busy (fixing #196). This might draw more power than before in this specific case, but the alternative would be far less pleasant for the student should an exam invigilator notices the lack of proper calculator blinkingness. |
4f0a20f
to
4b52456
Compare
Change
Ion::msleep
from a CPU busy-loop to a timer busy-loop. Ideally we'd put the MCU to sleep while sleeping to save on power, but we don't handle interrupts yet.Also adding register definitions for #311 and a bugfix while I'm here.