Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entry describing how to add 'global using' in a Directory.Build.props file #885

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add entry describing how to add 'global using' in a Directory.Build.props file #885

merged 3 commits into from
Jan 22, 2024

Conversation

manfred-brands
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

Preview link: https://65ae726d9b489007cd93579f--resilient-maamoul-8b1e0d.netlify.app

SeanKilleen
SeanKilleen requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Minor changes requested.

docs/articles/nunit/release-notes/Nunit4.0-MigrationGuide.md Outdated Show resolved Hide resolved
docs/articles/nunit/release-notes/Nunit4.0-MigrationGuide.md Outdated Show resolved Hide resolved
docs/articles/nunit/release-notes/Nunit4.0-MigrationGuide.md Outdated Show resolved Hide resolved
manfred-brands and others added 2 commits January 22, 2024 14:38
@manfred-brands @SeanKilleen
Apply suggestions from code review
030a3f7 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@manfred-brands
Clean up sentence
c3e2358
SeanKilleen
SeanKilleen approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@SeanKilleen SeanKilleen merged commit 8568f28 into master Jan 22, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
@SeanKilleen
Add entry describing how to add 'global using' in a Directory.Build.p…
eca9228 
…rops file (#885)

* Add entry describing how to add 'global using' in a Directory.Build.props file.

* Apply suggestions from code review

Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>

* Clean up sentence

---------

Co-authored-by: Sean Killeen <SeanKilleen@gmail.com> 8568f28
@manfred-brands manfred-brands deleted the MigrationGuideUpdate branch February 22, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanKilleen SeanKilleen SeanKilleen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manfred-brands @SeanKilleen