Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect the 'partition' token during filter element parsing #1345

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Detect the 'partition' token during filter element parsing #1345

merged 1 commit into from
Oct 16, 2023

Conversation

Plasma
Copy link
Contributor

@Plasma Plasma commented May 22, 2023 •
edited by stevenaw

This adds support for a new PartitionFilter at nunit/nunit#4392 nunit/nunit#4391

@Plasma Plasma mentioned this pull request May 22, 2023
Closed
@Plasma Plasma marked this pull request as ready for review May 22, 2023 13:27
@OsirisTerje
Copy link
Member

@Plasma Thanks for this. In order to get this into the adapter, you have to create similar PRs tom branch version315. Further, another PR is needed for 'master' which handles the 4.0. I am not sure if we will continue the 3.16 series, due to the critical loading issues we have there. Can be better to jump straight to 4.X.

@Plasma
Copy link
Contributor Author

Plasma commented Jun 7, 2023

Thanks @OsirisTerje I've opened PR #1346 and #1347

@stevenaw stevenaw mentioned this pull request Jul 24, 2023
Open
@OsirisTerje OsirisTerje merged commit 430d207 into nunit:version3 Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Plasma @OsirisTerje