Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PartitionFilter to run a subset of tests based off a hash/partition key #4392

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

Plasma
Copy link
Contributor

@Plasma Plasma commented May 22, 2023

Overview

Added a new filter, PartitionFilter, that allows you to filter to a subset of arbitrary tests based on a partition number and count.

This is helpful when you may want to run a subset of tests (eg, across 3 machines - or partitions), each with a separately assigned partition number and fixed partition count

Fixes #4391

@Plasma
Copy link
Contributor Author

Plasma commented May 22, 2023

@dotnet-policy-service agree

@Plasma Plasma changed the base branch from master to v3.13-dev May 22, 2023 11:41
@manfred-brands
Copy link
Member

You changed the PR to be relative to v13.3 bit it contains all v4 commits.

@Plasma Plasma marked this pull request as draft May 22, 2023 11:51
…ubset of arbitrary tests based on a partition number and count

This is helpful when you may want to run a subset of tests (eg, across 3 machines - or partitions), each with a separately assigned partition number and fixed partition count

Fixes nunit#4391
@Plasma
Copy link
Contributor Author

Plasma commented May 22, 2023

You changed the PR to be relative to v13.3 bit it contains all v4 commits.

I've re-based and force-pushed my changes to be under the v3.13-dev branch, looks better now.

Plasma added a commit to Plasma/nunit-console that referenced this pull request May 22, 2023
Plasma added a commit to Plasma/nunit-console that referenced this pull request May 22, 2023
@Plasma Plasma marked this pull request as ready for review May 22, 2023 13:26
Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OsirisTerje OsirisTerje merged commit 9b46601 into nunit:v3.13-dev Jun 3, 2023
5 checks passed
Plasma added a commit to Plasma/nunit-console that referenced this pull request Jun 6, 2023
Plasma added a commit to Plasma/nunit-console that referenced this pull request Jun 7, 2023
@stevenaw
Copy link
Member

stevenaw commented Jun 10, 2023

Thanks for your contribution @Plasma !
Would you be able to create a separate PR against the master/main branch to ensure that your changes will continue to be in future major releases of NUnit?

@Plasma
Copy link
Contributor Author

Plasma commented Jun 15, 2023

Thanks @stevenaw I've just made PR #4402

@stevenaw
Copy link
Member

Thanks @Plasma ! Appreciate your assistance getting this change into all the necessary places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash/Partition based Test Filter
4 participants