Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop or at least make Travis not required? #3195

Closed
rprouse opened this issue Mar 18, 2019 · 8 comments
Closed

Drop or at least make Travis not required? #3195

rprouse opened this issue Mar 18, 2019 · 8 comments

Comments

@rprouse
Copy link
Member

rprouse commented Mar 18, 2019

We now have Azure DevOps Pipelines builds for NUnit, the NUnit Console/Engine and the Adapter running on all supported platforms. Our Travis builds have always been really slow and somewhat flaky. Based on that, I propose;

  • Make our Azure DevOps Pipelines Required for PRs
  • Make our Travis builds optional
  • Possibly drop our Travis builds?

I'm entering the issue in this project, but I am thinking of doing this in the console/engine and adapter too, so I'd like it if the @nunit/core-team could comment. Based on our decision, I can create issues in the other projects.

@rprouse
Copy link
Member Author

rprouse commented Mar 18, 2019

I forgot that the console/engine project doesn't have Azure DevOps pipelines builds yet. I will enter an issue to get them setup.

@rprouse
Copy link
Member Author

rprouse commented Mar 18, 2019

Sorry, jumping around too much today. @jnm2 has the PR for the Azure DevOps pipeline builds in the console project.

@jnm2
Copy link
Contributor

jnm2 commented Mar 18, 2019

I'm in favor of dropping Travis even if it wasn't slow since it is redundant.

@CharliePoole
Copy link
Contributor

Redundancy can be good. 😄

@rprouse
Copy link
Member Author

rprouse commented Mar 18, 2019

I agree that redundancy is good and I'd advocate for keeping Travis if it wasn't for the number of Travis builds that fail for unrelated reasons. It has been more stable recently, but I don't have much faith in their future stability. I've heard they were acquired and that a large number of their developers were let go.

@mikkelbu
Copy link
Member

Personally, I prefer doing it in steps: first make our Travis builds optional, and then after some time drop them if they provide more pain than value.

@rprouse
Copy link
Member Author

rprouse commented Mar 19, 2019

That is an excellent way of thinking about it @mikkelbu, let's go with that.

@rprouse
Copy link
Member Author

rprouse commented Apr 28, 2019

I've made Azure DevOps required and dropped Travis as required on this repo and in NUnit Console.

@rprouse rprouse closed this as completed Apr 28, 2019
@rprouse rprouse added this to the 3.12 milestone Apr 28, 2019
mikkelbu added a commit that referenced this issue Jan 16, 2021
Travis CI builds were made optional in #3195 and removed in #3383, but some
references to Travis was still left in the code-base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants