Fix open generic type deductions #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but can you add some unit tests? |
|
Done, I found a way to ensure the existing test cover this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4243
When I investigated why it was resolving to double, double, I found that it would try to get the best common type twice for each type args because of this
IsGenericParametercondition rather than match them via their underlying type. I found it odd: why would it try to check matches between the first arg with the second type param and the second arg with the first one?I ran some git blame and I found that this if was added as a result of #358 and while I am not too familiar with the project's history, I did some research and it seems NETCF support was removed in this repository a long time ago. It seems to me that it was added due to generics being weirder to support on that platform, but since it isn't supported anymore, it seems that it should be removed if it causes problems which I think it does here.