Addition of DictionaryContainsKeyValuePairConstraint #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprouse
previously approved these changes
Mar 5, 2020
Falco20019
changed the title
|
@rprouse / @nunit/framework-team |
mikkelbu
reviewed
Apr 1, 2020
src/NUnitFramework/tests/Constraints/DictionaryContainsKeyValueConstraintTests.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/DictionaryContainsKeyValuePairConstraint.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/tests/Constraints/DictionaryContainsKeyValueConstraintTests.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/DictionaryContainsKeyConstraint.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/DictionaryContainsKeyValuePairConstraint.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/DictionaryContainsKeyConstraint.cs
Outdated
Show resolved
Hide resolved
…ValuePairConstraint.cs Co-Authored-By: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
…eConstraintTests.cs Co-Authored-By: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
…ValuePairConstraint.cs Co-Authored-By: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
…Constraint.cs Co-Authored-By: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
…eConstraintTests.cs
mikkelbu
approved these changes
May 7, 2020
|
Thanks for supplying this PR @Falco20019, and sorry about the slow feedback from our side. |
|
Thanks for updating the PR. I totally forgot that I had open suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3470
Just a first idea to resolve it. Not sure if I implemented
WithValueinDictionaryContainsKeyConstraintcorrectly. Also not sure if usingKeyValuePair<TKey, TValue>is better or using the approach already used for properties (ResolvableConstraintExpression?) is better. This seemed to have worked forDoes.ContainKey.WithValueand alsoDoes.Not.ContainKey.WithValue.Looking forward to feedback :)