3.13.3 Regression - CollectionTally correctly handles ImmutableDictionary again #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenaw
commented
Apr 15, 2022
| @@ -170,10 +170,8 @@ void TryRemoveSlow(IEnumerable c) | |||
|
|
|||
| private static ArrayList ToArrayList(IEnumerable items) | |||
| { | |||
| if (items is ICollection ic) | |||
| return new ArrayList(ic); | |||
| var list = items is ICollection ic ? new ArrayList(ic.Count) : new ArrayList(); | |||
There was a problem hiding this comment.
ImmutableDictionary.CopyTo will convert the underlying type which is why the ctor which took in an ICollection was failing, but we can at least initialize the ArrayList to the proper size if it is known
mikkelbu
added a commit
that referenced
this pull request
Apr 20, 2022
Cherrypick PR #4097 onto main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4095
Allows CollectionTally to work with ImmutableDictionary properly again by avoiding a bulk-add for the ICollection case