Skip to content

Cherrypick PR #4097 onto main - #4098

Merged
mikkelbu merged 4 commits into
nunit:masterfrom
stevenaw:4095-foreport
Apr 20, 2022
Merged

mikkelbu merged 4 commits into
nunit:masterfrom
stevenaw:4095-foreport

Conversation

@stevenaw

Copy link
Copy Markdown
Member

Contributes to #4095
Migrates the fix from PR #4097 onto v4 / main

Contains 2 extra commits:

  • 1 to remove the unneeded net35/40 ifdefs from tests related to the bugfix
  • 1 to remove some unneeded net35/40 ifdefs from a test unrelated to the bugfix

@stevenaw stevenaw added this to the 4.0 milestone Apr 20, 2022

@manfred-brands manfred-brands left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches 3.13 changes

@mikkelbu mikkelbu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants