Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick PR #4097 onto main #4098

Merged
merged 4 commits into from Apr 20, 2022
Merged

Cherrypick PR #4097 onto main #4098

merged 4 commits into from Apr 20, 2022

Conversation

stevenaw
Copy link
Member

Contributes to #4095
Migrates the fix from PR #4097 onto v4 / main

Contains 2 extra commits:

  • 1 to remove the unneeded net35/40 ifdefs from tests related to the bugfix
  • 1 to remove some unneeded net35/40 ifdefs from a test unrelated to the bugfix

@stevenaw stevenaw added this to the 4.0 milestone Apr 20, 2022
manfred-brands
manfred-brands approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches 3.13 changes

mikkelbu
mikkelbu approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikkelbu mikkelbu merged commit c5d2930 into nunit:master Apr 20, 2022
@OsirisTerje OsirisTerje mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

@manfred-brands manfred-brands manfred-brands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenaw @mikkelbu @manfred-brands