When running dotnet test with filter, all tests are run and all console output is logged. #941
Comments
|
Also seeing this issue on Windows |
|
Thanks @ptmclean and @JohnDoeKyrgyz . This seems to happen when an assembly doesn't have any tests matching that filter. Please confirm if that is what you see. About the console output, that was a change introduced in Version 4.2.0, responding to issue #934. |
Yes, and an assembly that actually doesn't contain any tests at all does output the warning as expected. That NuPKG does fix the issue btw 👍 |
|
Great thanks @OsirisTerje! Sorry I've been slow to get back to you. I think that works well. I've pushed up the reference to the test package in the repro repo. Looks good to me! |
|
Thanks! I'll get it out as soon as possible :-) |
…solved Tests have started to output too much log content, causing viewing CI failures to be painfully impossible. Roll back for now. Fix may be related to nunit/nunit3-vs-adapter#941, although we don't use filter.
* Fixing Issue #941 * updating acceptance tests * Update tests
|
Release 4.2.1 is on nuget.org. |
|
Works for me as well. Great 👍 |
When running a test using the cli(
dotnet test) and using a--filterall tests are run but only the results from the filtered tests are reported. A simple repro can be found here. The output from the test run only includes information from the matching test but the non-matching tests also run.The NUnit version here is 3.13.2 and Adapter version 4.2.0 with dotnet 6.0.101 on an ARM Mac. I can't be sure it is not an engine issue, but changing the version of the adapter back to 4.1.0 returns to the previous behaviour.
There is another change with this version where the console output is logged for all tests whether they pass or fail. This may well be OS/console specific...
The text was updated successfully, but these errors were encountered: