Update asc_editor.py to fix iteration error in get_component_info #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change get_component_info to iterate over the key, value pairs in the component.attributes dictionary. Previously, it iterated directly on the dictionary, which in recent versions of Python is equivalent to iterating over only the keys.
|
That was actually a bug that missed my attention Thanks for solving it. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change get_component_info to iterate over the key, value pairs in the component.attributes dictionary. Previously, it iterated directly on the dictionary, which in recent versions of Python is equivalent to iterating over only the keys.