Make the cyclomatic complexity limit configurable. #190
Conversation
|
Good idea, I have changed it. |
There was a problem hiding this comment.
@tvbeek Can you run composer test locally? Tests are not passing.
|
Yes, sorry I just saw it. Currently working on it. |
… errors from phpinsights
|
It passed the test, do you have anything else that you like to have changed? |
|
Great addition 👍 Thank you @tvbeek 🙏 If you can, can you also update documentation to help users to know how to configure it ? You just have to add in https://github.com/nunomaduro/phpinsights/blob/master/docs/insights/complexity.md something like + <details>
+ <summary>Configuration</summary>
+
+ ```php
+ \NunoMaduro\PhpInsights\Domain\Insights\CyclomaticComplexityIsHigh::class => [
+ 'maxComplexity' => 5
+ ]
+ ```
+ </details>after Insight Class: |
|
@olivernybroe There wasn't a test for this insight but I will create it. @Jibbarth thanks for pointing out to the documentation. I have added it. |
|
I have added a test for the CyclomaticComplexityIsHigh Insight that test this config (and the normal behavior) |
|
@nunomaduro @Jibbarth I'll say this is ready for merge. So if one of you agree with me, just merge it in :) |
…n and update the documentation so that the configuration is visible. Thanks @Jibbarth for the feedback.
|
@Jibbarth @olivernybroe Tonight I will release a new version of php insights. |
|
Thanks @tvbeek for this pull request. |
I found that I wanted to change the limit of the cyclomatic complexity insight. Currently this is hard coded fixed on 5. So with this PR I add the option to change it.