Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(details): Add diff to details class #356

Merged
merged 9 commits into from
Feb 10, 2020

Conversation

olivernybroe
Copy link
Collaborator

@olivernybroe olivernybroe commented Feb 7, 2020

Q A
Bug fix? yes
New feature? yes

This PR adds the diff to the details class, this is needed so the JSON can output the diff separately.

I also moved the coloring in the diff into the console formatter.

Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally agree with that change 👍

Just left a minor comment

src/Application/Console/Formatters/Console.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@olivernybroe olivernybroe merged commit a6fac78 into nunomaduro:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants