add requirement versions #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtya
requested review from
inishchith,
nurdtechie98,
parulagg27,
sauravchirania and
shivam1708
as code owners
inishchith
approved these changes
Apr 6, 2019
There was a problem hiding this comment.
@adtyanair Thanks for the changes. LGTM. @shivam1708 can you have a look at this?
|
@adtyanair Sorry for late reply. It looks fine to me. windows-curses has a latest version of 1.1. |
|
@nurdtechie98 can you just check about windows-curses? |
shivam1708
approved these changes
Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request towards #27
add versions for all the requirements except 'windows-curses'.
I don't have a Windows system with me so I am not able to do anything on 'windows-curses'. It would be great if someone with a Windows system is able to help.