Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lambda00 for multi simplex model and x0 in homotopy_solver #15

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fix lambda00 for multi simplex model and x0 in homotopy_solver #15

merged 2 commits into from
Nov 15, 2022

Conversation

FreyJo
Copy link
Collaborator

@FreyJo FreyJo commented Nov 14, 2022 •
edited

#14 was not meant to be merged already. Sorry should have clearified this.
I found two related bugs and now the friction block example works again.

@FreyJo FreyJo changed the title Fix lambda00 Fix lambda00 for multi simplex model and x0 in homotopy_solver Nov 14, 2022
nurkanovic
nurkanovic approved these changes Nov 15, 2022
View reviewed changes
Copy link
Owner

@nurkanovic nurkanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks.
I am only wondering why do not we have also for the "step" case a function for lambda_00, but only an expression, cf. line 52 in homotopy_solver.
We might consider to make a casadi function for it as well.

@nurkanovic nurkanovic merged commit 53f3008 into nurkanovic:main Nov 15, 2022
@FreyJo FreyJo deleted the fix_lambda00 branch November 15, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurkanovic nurkanovic nurkanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FreyJo @nurkanovic