Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lambda00 to fix implicit Euler, Cleanup parameters #14

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Add lambda00 to fix implicit Euler, Cleanup parameters #14

merged 4 commits into from
Nov 14, 2022

Conversation

FreyJo
Copy link
Collaborator

@FreyJo FreyJo commented Nov 11, 2022

TODO: fix for Step.

nurkanovic
nurkanovic approved these changes Nov 14, 2022
View reviewed changes
Copy link
Owner

@nurkanovic nurkanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are fine, the naming is convient.
I believe that for "Step" lambda_00 has the dimension 2n_theta.
We should use n_lambda in the next update, which is
for Stewart n_lambda = n_theta and for Step n_lambda = 2n_theta.

@nurkanovic nurkanovic merged commit f8c6aae into main Nov 14, 2022
@FreyJo FreyJo mentioned this pull request Nov 14, 2022
Merged
@FreyJo FreyJo deleted the dev branch November 20, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurkanovic nurkanovic nurkanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FreyJo @nurkanovic