Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all discretization options from model to problem_options #50

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

FreyJo
Copy link
Collaborator

@FreyJo FreyJo commented Aug 25, 2023

These are

  • T_sim
  • N_sim
  • h_sim
  • h
  • h_k
  • T

@FreyJo FreyJo requested a review from apozharski August 25, 2023 09:40
s_sot0(1,1) double {mustBePositive} = 1
s_sot_max(1,1) double {mustBePositive} = 25
s_sot_min(1,1) double {mustBePositive} = 1
S_sot_nominal(1,1) double {mustBePositive} = 1
rho_sot(1,1) double {mustBeReal, mustBeNonnegative} = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the mustBeReal from here as well, but not super important.

Copy link
Collaborator

@apozharski apozharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but I can handle it later when we do a cleanup pass.
LGTM 🚀

@apozharski apozharski merged commit 9c4ea37 into main Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants