Add labels to asm export #100
Comments
|
Also I noticed that you assign the border and bg colors directly like For consistency, I'd recommend to assign these in the same modular way as the chars and colram, therefore |
|
All of this makes sense. Will implement maybe even for 0.4 already. |
|
Cool! While you are at it, I think it makes sense to put the bg+border colors at the end of the data section, this would save you the many +2 additions on char and colram copy code, like: |
|
I implemented #100 (comment) now. The last #100 (comment) I'd prefer not to implement because that'd change the binary layout of the .asm files. There are probably not many users of petmate generated .asm files but at least Viza already made a demo with Petmate asms. If I change it, any code using Petmate .asm exported files would break. The adds are free as it's the assembler that computes the add. Not sure how useful the color & screen labels are. If you know the binary layout, then at least in KickAssembler you can do Why not add them? Well, the fewer symbols the .asm defines, the less chance there is for a name conflict between .asm exported files and the code using it. |
|
Nice that you are concerned about me, but not necessary :) Anyway, in that particular case, I used the C export, and ignored the bg/border colors completely (cause that was the same for the whole intro). Well, most of this doesn't matter, just sharing my workflow :) |
Well, this scripting language already exists. It's called Python. :) Shouldn't be too hard to load either .c or .asm files (or just .petmate) and then re-export into any output format. |
|
Well, actually petmate has already support for a scripting language, called javascript :) |
|
I agree with Viza, no way to please everybody. I'm actually okay with not adding more labels, your have valid points for not doing it nurpax. As for the position of the border and bg bytes, I can rearrange them by hand I guess. |
|
@Esshahn: I don’t understand why the adds are a problem? The machine code will be the same in both cases, just the ptr offset changes and that’s computed by the assembler. Marq’s petscii .c also has the colors at the beginning so I just went with that since to me this is just a comvention. |
|
Nevermind, it's really just me trying to make my code work :D The "modular" petscii display routine is basically working with your asm format, just some optimization and correcting the 4th loop length needed. |
Marq is adding labels to the asm export, which makes it very easy to locate the colram.
Would this be working for petmate as well?
e.g.
The text was updated successfully, but these errors were encountered: