Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding git aliases #337

Merged
merged 4 commits into from
Jan 16, 2023
Merged

adding git aliases #337

merged 4 commits into from
Jan 16, 2023

Conversation

TornaxO7
Copy link
Contributor

@TornaxO7 TornaxO7 commented Jan 1, 2023

This PR basically adds most of the aliases from git.plugin.zsh which I often used when I was using zsh and I think that some other people might find them useful as well.

This PR also adds a new directory: aliases. The intention for this directory is that other alias-files which could come up in the future can be inteserted there to separate scripts, which "actually do something", from aliases.

@fdncred
Copy link
Collaborator

fdncred commented Jan 1, 2023

We need a description please. "This is a PR that ..."

@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Jan 1, 2023

I'm sorry! I'll edit it.

aliases/git/nu_alias_git.nu Outdated Show resolved Hide resolved
aliases/git/nu_alias_git.nu Outdated Show resolved Hide resolved
@fdncred
Copy link
Collaborator

fdncred commented Jan 1, 2023

In general, most of these look great an helpful. However, some of them look like they don't work. So, I'd ask that you test some of them with non-nushell syntax before we land this.

@TornaxO7 TornaxO7 marked this pull request as draft January 1, 2023 19:20
@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Jan 1, 2023

I'll mark this as a draft until I finished testing them and correcting some other stuff.

@TornaxO7 TornaxO7 marked this pull request as ready for review January 1, 2023 20:57
aliases/git/nu_alias_git.nu Outdated Show resolved Hide resolved
@fdncred
Copy link
Collaborator

fdncred commented Jan 16, 2023

@TornaxO7 is this pr ready to merge?

@TornaxO7
Copy link
Contributor Author

yes, it should be ready to merge

@fdncred fdncred merged commit 62a3cd1 into nushell:main Jan 16, 2023
@fdncred
Copy link
Collaborator

fdncred commented Jan 16, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants