Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the release note scripts #538

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jun 27, 2023

i was writing stuff for nushell/nushell.github.io#945 and noticed two issues with the make_release/release-note/ scripts.

this PR fixes both of them

  • add a # before the PR numbers in markdown links
  • the name of the Reedline repo is nushell/reedline not reedline

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx

@sholderbach sholderbach merged commit bc54b62 into nushell:main Jul 3, 2023
@amtoine amtoine deleted the fix/release-note-scripts branch July 3, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants