Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tix the release note PR opening script #611

Merged
merged 2 commits into from Sep 20, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Sep 20, 2023

to open nushell/nushell.github.io#1071, i had to fix a few issues in the create_pr script of make_release/ 馃憖

  • str replace --string has been removed in 0.85 yesterday
  • a return in the middle of the script won't help opening the PR automatically 馃槅

lol otherwise of course it won't work xD
@amtoine
Copy link
Member Author

amtoine commented Sep 20, 2023

as i've just run the script with these fixes, which created nushell/nushell.github.io#1071 successfully, i'll go ahead and land this PR 馃槍

@amtoine amtoine merged commit e64355b into nushell:main Sep 20, 2023
@amtoine amtoine deleted the fix-release-note-pr-script branch September 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant