Remove str replace --string after deprecation
#10064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
added
wait-until-after-nushell-release
pr:breaking-change
…tring-option this should solve the conflict in nushell#10064.
|
i will mark this as ready for review to have it ready for next release 👍 |
11 tasks
sholderbach
changed the title
str replace --stringstr replace --string after deprecation
amtoine
added a commit
to amtoine/scripts
that referenced
this pull request
Sep 19, 2023
related to nushell/nushell#10064 and Nushell 0.85.0.
fnordpig
pushed a commit
to fnordpig/nushell
that referenced
this pull request
Sep 19, 2023
related to - nushell#10038 # Description `str replace --string` has been deprecated in nushell#10038 and should be removed before 0.85. this PR removes the `--string` option from `str replace` completely. # User-Facing Changes `str replace --string` will no longer work and will give an error instead of a warning.
amtoine
added a commit
to amtoine/nu_scripts
that referenced
this pull request
Sep 20, 2023
amtoine
added a commit
to nushell/nu_scripts
that referenced
this pull request
Sep 20, 2023
* remove `str replace --string` related to nushell/nushell#10064 * remove the return lol otherwise of course it won't work xD
sholderbach
added
removal-after-deprecation
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
related to - nushell#10038 # Description `str replace --string` has been deprecated in nushell#10038 and should be removed before 0.85. this PR removes the `--string` option from `str replace` completely. # User-Facing Changes `str replace --string` will no longer work and will give an error instead of a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
str replaceto match substring by default #10038Description
str replace --stringhas been deprecated in #10038 and should be removed before 0.85.this PR removes the
--stringoption fromstr replacecompletely.User-Facing Changes
str replace --stringwill no longer work and will give an error instead of a warning.Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting