Skip to content

Commit

Permalink
Remove clippy global -A from CI (#10072)
Browse files Browse the repository at this point in the history
# Description
We allowed two default lints due to false positives. This should be
locally addressed with explicit information what causes either a false
positive or why a particular design choice in the code is made.


# User-Facing Changes
None

# Tests + Formatting
We should detect a few more things with clippy out of the box. If you
encounter a false positive you will need to address it on a case by case
basis.
  • Loading branch information
sholderbach committed Aug 20, 2023
1 parent bffd8e4 commit 43ceb3e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ name: continuous-integration
env:
NUSHELL_CARGO_TARGET: ci
NU_LOG_LEVEL: DEBUG
CLIPPY_OPTIONS: "-D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err"
CLIPPY_OPTIONS: "-D warnings -D clippy::unwrap_used"

jobs:
fmt-clippy:
Expand Down

0 comments on commit 43ceb3e

Please sign in to comment.