Remove clippy global -A from CI
#10072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allowed two default lints due to false positives. This should be locally addressed with explicit information what causes either a false positive or why a particular design choice in the code is made.
sholderbach
added a commit
that referenced
this pull request
Aug 20, 2023
Same procedure as in #10072
sholderbach
added a commit
that referenced
this pull request
Aug 20, 2023
# Description Same procedure as in #10072
sholderbach
pushed a commit
that referenced
this pull request
Aug 21, 2023
related to - #10072 - #10073 cc/ @sholderbach # Description i think the PR template was the missing place where a `cargo clippy` appears 😏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We allowed two default lints due to false positives. This should be locally addressed with explicit information what causes either a false positive or why a particular design choice in the code is made.
User-Facing Changes
None
Tests + Formatting
We should detect a few more things with clippy out of the box. If you encounter a false positive you will need to address it on a case by case basis.