Skip to content

Commit

Permalink
Hide 7925 (#8359)
Browse files Browse the repository at this point in the history
# Description

Hides #7925 from config and
disables by default. Option is still present in config, just hidden.

# User-Facing Changes

Users can no longer find `table.show_empty` in config and it is set to
false by default.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
  • Loading branch information
NotLebedev committed Mar 8, 2023
1 parent 0df847d commit d31a51e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion crates/nu-protocol/src/config.rs
Expand Up @@ -107,7 +107,7 @@ impl Default for Config {
Config {
filesize_metric: false,
table_mode: "rounded".into(),
table_show_empty: true,
table_show_empty: false,
external_completer: None,
use_ls_colors: true,
color_config: HashMap::new(),
Expand Down
1 change: 0 additions & 1 deletion crates/nu-utils/src/sample_config/default_config.nu
Expand Up @@ -187,7 +187,6 @@ let-env config = {
table: {
mode: rounded # basic, compact, compact_double, light, thin, with_love, rounded, reinforced, heavy, none, other
index_mode: always # "always" show indexes, "never" show indexes, "auto" = show indexes when a table has "index" column
show_empty: true # show 'empty list' and 'empty record' placeholders for command output
trim: {
methodology: wrapping # wrapping or truncating
wrapping_try_keep_words: true # A strategy used by the 'wrapping' methodology
Expand Down

0 comments on commit d31a51e

Please sign in to comment.