Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide 7925 #8359

Merged
merged 2 commits into from Mar 8, 2023
Merged

Hide 7925 #8359

merged 2 commits into from Mar 8, 2023

Conversation

NotLebedev
Copy link
Contributor

Description

Hides #7925 from config and disables by default. Option is still present in config, just hidden.

User-Facing Changes

Users can no longer find table.show_empty in config and it is set to false by default.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #8359 (aef8579) into main (0df847d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8359      +/-   ##
==========================================
- Coverage   68.53%   68.49%   -0.05%     
==========================================
  Files         620      620              
  Lines       99426    99426              
==========================================
- Hits        68145    68102      -43     
- Misses      31281    31324      +43     
Impacted Files Coverage Δ
crates/nu-protocol/src/config.rs 44.47% <100.00%> (-0.19%) ⬇️
crates/nu-color-config/src/text_style.rs 37.91% <0.00%> (-4.27%) ⬇️
crates/nu-command/src/viewers/table.rs 86.70% <0.00%> (-0.77%) ⬇️
crates/nu-parser/src/parser.rs 82.37% <0.00%> (-0.40%) ⬇️

@fdncred
Copy link
Collaborator

fdncred commented Mar 8, 2023

My exact setting. LOL

I think this is good enough to hide it for the next release. We just need to figure out what we're going to do with it.

@sophiajt sophiajt merged commit d31a51e into nushell:main Mar 8, 2023
@NotLebedev NotLebedev deleted the hide-7925 branch March 9, 2023 18:32
NotLebedev added a commit to NotLebedev/nushell that referenced this pull request Mar 17, 2023
@NotLebedev NotLebedev mentioned this pull request Mar 17, 2023
sophiajt pushed a commit that referenced this pull request Mar 17, 2023
Revert #8359
Turn `[empty list]` on by default again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants