Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uutils/coreutils commands into nushell #11549

Open
5 of 16 tasks
fdncred opened this issue Jan 16, 2024 · 8 comments
Open
5 of 16 tasks

add uutils/coreutils commands into nushell #11549

fdncred opened this issue Jan 16, 2024 · 8 comments
Labels
coreutils-uutils Changes relating to coreutils/uutils enhancement New feature or request

Comments

@fdncred
Copy link
Collaborator

fdncred commented Jan 16, 2024

Related problem

This is a tracking issue to add the agreed to uutils/coreutils commands to nushell

Describe the solution you'd like

We'd like to implement all these commands using uutils/coreutils. Some work may have to be done on the uutils/coreutils side. All the commands so far have had to have options exposed.

If you'd like to sign up for one of these commands, feel free to post below and we can put your name by the command.

Describe alternatives you've considered

No response

Additional context and details

Original tracking issue in uutils/coreutils uutils/coreutils#5088

@dmatos2012
Copy link
Contributor

I could volunteer for uname seems very straightforward tho. Initially, we would have to see again how many flags we are going to support, but we can give it the initial roll out :)

@fdncred
Copy link
Collaborator Author

fdncred commented Jan 19, 2024

Sounds good @dmatos2012. I'll put your name by it. Hopefully a very different experience from uu_cp and uu_mv. 😆

@ysthakur
Copy link
Member

I can try to work on touch

@fdncred
Copy link
Collaborator Author

fdncred commented Jan 30, 2024

Thanks @ysthakur I added you above.

@jokeyrhyme
Copy link
Contributor

jokeyrhyme commented Feb 12, 2024

In terms of general direction/expectations, if a coreutils implementation doesn't work on Windows, is it acceptable to replace the UNIX/Linux/macOS behaviour with coreutils and leave the pre-coreutils implementation alone for Windows?

Or do we need to try to get upstream coreutils to work on Windows first, so that it can completely replace what we have here in nushell?

@fdncred
Copy link
Collaborator Author

fdncred commented Feb 12, 2024

We want to use the cross-platform coreutils. We do not want to have a separate implementation for Windows and Unix.

@dmatos2012
Copy link
Contributor

@fdncred). I was curious about du but I see that we already have pretty tables and all as output, so are we still planning on replacing it?

Additionally, all the other commands have a huge number of flags, shall we consider how many are we going to support for some of them? I can envision maybe df being nushell-like with almost no flags, but the others seem that they are too unstructured. Thoughts?

A

@fdncred
Copy link
Collaborator Author

fdncred commented Mar 6, 2024

@dmatos2012 The general idea is to migrate all the commands listed. As far as flags, we just need to add the most popular ones as a first pass, or the ones that already exist in the nushell built-in command. If people want other flags, we may add them via separate PR. I'm fine with discussing flags in a per command PR basis.

Keep in mind, that one of the reasons why we chose to add coreutils utilities is because it lowers the maintenance costs for us once it's in, or at least that's the idea. We have all these excellent tools that they created, and we'd like to use them. I agree that 100 flags is not the nushell way, but we should just start somewhere and go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coreutils-uutils Changes relating to coreutils/uutils enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants