Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utouch command from uutils/coreutils #11817

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

ysthakur
Copy link
Member

@ysthakur ysthakur commented Feb 9, 2024

Part of #11549

Description

This PR adds a utouch command that uses the touch command from https://github.com/uutils/coreutils. Eventually, utouch may be able to replace touch.

The conflicts in Cargo.lock and Cargo.toml are because I'm using the uutils/coreutils main rather than the latest release, since the changes that expose uu_touch's internal functionality aren't available in the latest release.

User-Facing Changes

Users will have access to a new utouch command with the following flags:
todo

Tests + Formatting

After Submitting

@fdncred fdncred added the coreutils-uutils Changes relating to coreutils/uutils label Feb 9, 2024
@fdncred
Copy link
Collaborator

fdncred commented Feb 26, 2024

@ysthakur What's the latest here?

@ysthakur
Copy link
Member Author

@fdncred Sorry, I've been really busy and haven't touched this for a week. The uutils side is currently not ready but I think I know what to do, and I'll be updating that today or tomorrow. Hopefully we can get that one merged by the end of the week

@fdncred
Copy link
Collaborator

fdncred commented Feb 26, 2024

Thanks for the heads-up @ysthakur. I appreciate your efforts here.

@fdncred
Copy link
Collaborator

fdncred commented Mar 13, 2024

How's this going? Are we waiting for changes to land at coreutils?

@ysthakur
Copy link
Member Author

@fdncred Yeah, I just pinged Terts. Here's the PR, forgot to link it before: uutils/coreutils#5946.

@fdncred
Copy link
Collaborator

fdncred commented Apr 12, 2024

@ysthakur Is there any hope to getting the coreutils PR landed?

@ysthakur
Copy link
Member Author

@fdncred Yes, sorry I've left it alone for a while. I wasn't quite sure how to interpret Terts's suggestions, but I just pushed a commit and will be bothering him about it :)

@fdncred
Copy link
Collaborator

fdncred commented Apr 12, 2024

ok, thanks for the update. appreciate your help.

@fdncred
Copy link
Collaborator

fdncred commented May 24, 2024

time for my check in again. what's the status here?

@ysthakur
Copy link
Member Author

@fdncred Currently waiting on a review for the PR I made in uutils/coreutils.

@fdncred
Copy link
Collaborator

fdncred commented Jul 9, 2024

@ysthakur wow! the uutils pr landed. we can finally progress on this one. yipee!

@ysthakur ysthakur marked this pull request as ready for review July 12, 2024 22:27
@ysthakur
Copy link
Member Author

ysthakur commented Jul 12, 2024

I think touch is accidentally added to the default shell context twice, once with the filesystem commands and once with the format commands. I only added UTouch once there, with the filesystem commands.

Edit: Fixed in #13371.

@ysthakur ysthakur marked this pull request as draft July 12, 2024 22:31
@fdncred
Copy link
Collaborator

fdncred commented Jul 13, 2024

good catch. I don't think it should be the formats section.

@ysthakur
Copy link
Member Author

By the way, this PR isn't dead, it's just that there's a bug in the way uutils parses dates (uutils/coreutils#6629). I think I've found the cause, more or less, and am working on a fix there.

@fdncred
Copy link
Collaborator

fdncred commented Aug 27, 2024

Thanks for the update yash. Sorry this is such a hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coreutils-uutils Changes relating to coreutils/uutils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants