Start removing colour config from explore
#10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I think this is right. The only thing I was thinking about was whether accessing the colors via the StyleComputer is right. I was originally thinking that we'd just pull from the config, but after looking at more code, StyleComputer does that already, of course, so I think we're good to go here.
|
Thanks for the quick review! |
rgwood
added a commit
that referenced
this pull request
Oct 1, 2023
Remove code for 2 no-longer-used configuration options in `explore`: `explore.config.cursor_color` and `explore.config.border_color`. Think I made these unnecessary in #10533 and #10270 but missed this code, my bad. The `explore` config code is a little hard to follow because it does so many key lookups in hashmaps.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
Remove code for 2 no-longer-used configuration options in `explore`: `explore.config.cursor_color` and `explore.config.border_color`. Think I made these unnecessary in nushell#10533 and nushell#10270 but missed this code, my bad. The `explore` config code is a little hard to follow because it does so many key lookups in hashmaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
explore.try.border_colorconfig item, and instead always uses theseparatorcolour (the one used for regular table borders) from the current theme.The PR also removes some unused
explore.configbits from the default config (I missed this in #10259).Future Work
This PR is intentionally small, I want to confirm that I'm on the right track before I rip out more colour config from
explore. If all goes well, expect more PRs like this soon.Testing
I confirmed that this works by changing my
separatorcolour inconfig.nu, and also confirmed that nothing breaks if a user still hasexplore.try.border_colorin their config.