explore: highlight selected cell using background colour instead of cursor
#10533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've done this for a while now and it does make a huge difference. Thanks for working on this! |
rgwood
added a commit
that referenced
this pull request
Oct 1, 2023
Remove code for 2 no-longer-used configuration options in `explore`: `explore.config.cursor_color` and `explore.config.border_color`. Think I made these unnecessary in #10533 and #10270 but missed this code, my bad. The `explore` config code is a little hard to follow because it does so many key lookups in hashmaps.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
… cursor (nushell#10533) More incremental `explore` improvements! This PR removes the `show_cursor` config from the `explore` command, in favour of always using the background colour to highlight the selected cell. I believe this is a better default and I'd like to remove the `show_cursor` functionality entirely as part of the effort to simplify `explore`. The style for selected cells is still configurable. I went with light blue for the default background colour, it looks OK to me. ## Before:  ## After: 
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
Remove code for 2 no-longer-used configuration options in `explore`: `explore.config.cursor_color` and `explore.config.border_color`. Think I made these unnecessary in nushell#10533 and nushell#10270 but missed this code, my bad. The `explore` config code is a little hard to follow because it does so many key lookups in hashmaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More incremental
exploreimprovements!This PR removes the
show_cursorconfig from theexplorecommand, in favour of always using the background colour to highlight the selected cell. I believe this is a better default and I'd like to remove theshow_cursorfunctionality entirely as part of the effort to simplifyexplore.The style for selected cells is still configurable. I went with light blue for the default background colour, it looks OK to me.
Before:
After: