Upgrade softprops/action-gh-release to v0.1.15 for release and nightly build workflow #10331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's land it and test it in the nightly release，we can revert it if it doesn't work |
|
No more warnings here: https://github.com/nushell/nightly/actions/runs/6166802461 |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
softprops/action-gh-releaseto v0.1.15 for release and nightly build workflowsoftprops/action-gh-release@v0.1.13 uses
node12and there are lots of warnings here: https://github.com/nushell/nushell/actions/runs/5944081632We make it stay at v0.1.13 due to this issue, but we can try to update it with this workaround and test it in our nightly release repo: https://github.com/nushell/nightly to make sure that it works for the next release.