Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern does not match any files #280

Open
martinrotter opened this issue Nov 21, 2022 · 12 comments
Open

Pattern does not match any files #280

martinrotter opened this issue Nov 21, 2022 · 12 comments

Comments

@martinrotter
Copy link

Here is output of "dir":

    Directory: D:\a\rssguard\rssguard\rssguard-build

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          11/21/2022  1:24 PM       22695723 rssguard-devbuild-94d41d8a-nowebengine-win7.7z
-a---          11/21/2022  1:25 PM       25244134 rssguard-devbuild-94d41d8a-nowebengine-win7.exe

But my script does not produce expected result:

Run softprops/action-gh-release@v1
  with:
    prerelease: true
    name: Development builds
    tag_name: devbuild
    files: .\rssguard-build\rssguard-*win7.exe
  .\rssguard-build\rssguard-*win7.7z
  .\rssguard-build\rssguard-*win10.exe
  .\rssguard-build\rssguard-*win10.7z
  ./rssguard-build/rssguard-*mac64.dmg
  ./rssguard-build/rssguard-*linux64.AppImage
  
    token: ***
  env:
    GITHUB_TOKEN: ***
  
🤔 Pattern '.\rssguard-build\rssguard-*win7.exe' does not match any files.
🤔 Pattern '.\rssguard-build\rssguard-*win7.7z' does not match any files.

Pattern should clearly match and it did match some weeks/month ago without any related changes in my code. Maybe some regression in your great code. :)

@johannesnormannjensen
Copy link

We get the same output as we are running this on our own self-hosted runner on our windows server 2019 machine.
It's because this only works on POSIX paths al of a sudden.

Could it have something to do with the latest dep update of actions/glob?

@johannesnormannjensen
Copy link

For now our workaround is: uses: softprops/action-gh-release@v0.1.13

@softprops
Copy link
Owner

Thanks for the report. In the most recent update, the glob dep was upgraded from 7.1.6 to 8.

https://github.com/isaacs/node-glob/blob/main/changelog.md#80

I see some changes which look like they affect windows users regarding the \ the character

@softprops
Copy link
Owner

The latest glob readme recommends using forward slashes on windows https://github.com/isaacs/node-glob#windows

I think I might be able to make this backwards compatible by detecting windows trying as is and then falling back by trying to replace \ with /

Ho-Ro added a commit to OpenHantek/OpenHantek6022 that referenced this issue Nov 21, 2022
latest action-gh-release broken with mixed win path:
D:\a\OpenHantek6022\OpenHantek6022/build/packages/* not include valid file.

Signed-off-by: Martin <Ho-Ro@users.noreply.github.com>
@martinrotter
Copy link
Author

The latest glob readme recommends using forward slashes on windows https://github.com/isaacs/node-glob#windows

I think I might be able to make this backwards compatible by detecting windows trying as is and then falling back by trying to replace \ with /

I see. OK, I migrated to forward slashes, which I like more than backward ones anyway.

Thanks.

@Ho-Ro
Copy link

Ho-Ro commented Nov 22, 2022

OK, I migrated to forward slashes, which I like more than backward ones anyway.

Me too, but sometimes we're confronted with the nasty windows behaviour of backslashed pathes :(

      ...
      uses: softprops/action-gh-release@v1
      with:
        prerelease: true
        files: ${{github.workspace}}/build/packages/*
      ...

This gives:

🤔 Pattern 'D:\a\OpenHantek6022\OpenHantek6022/build/packages/*' does not match any files.
🤔 D:\a\OpenHantek6022\OpenHantek6022/build/packages/* not include valid file.

Any chance to "rectify" the ${{github.workspace}} pattern?

As a quick fix I reverted to action-gh-release@v0.1.13 as proposed above.

iqfareez added a commit to iiumschedule/iium_schedule that referenced this issue Dec 18, 2022
rux616 added a commit to rux616/biraitbec-workbase-improved that referenced this issue Dec 21, 2022
psavery added a commit to OpenChemistry/tomviz-superbuild that referenced this issue Jan 6, 2023
Until this is fixed: softprops/action-gh-release#280

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
pszentiv added a commit to Varian-MedicalAffairsAppliedSolutions/MAAS-PlanScoreCard that referenced this issue Jan 9, 2023
Set release step version back to v0.1.13 because of bug, see: softprops/action-gh-release#280
@Ho-Ro
Copy link

Ho-Ro commented Jan 10, 2023

The latest glob readme recommends using forward slashes on windows https://github.com/isaacs/node-glob#windows

I think I might be able to make this backwards compatible by detecting windows trying as is and then falling back by trying to replace \ with /

Any progress?

@martinrotter
Copy link
Author

I switched to forward slashes, honestly why care?

@Ho-Ro
Copy link

Ho-Ro commented Jan 10, 2023

Because sometimes e.g. ${{github.workspace}} forces backslashes like in my example above.

@martinrotter
Copy link
Author

You can replace ${{github.workspace}} with . (dot) to have same effect.

https://github.com/martinrotter/rssguard/blob/master/.github/workflows/rssguard.yml#L91

Ho-Ro added a commit to OpenHantek/OpenHantek6022 that referenced this issue Jan 10, 2023
softprops/action-gh-release#280

Signed-off-by: Martin <Ho-Ro@users.noreply.github.com>
Ho-Ro added a commit to OpenHantek/OpenHantek6022 that referenced this issue Jan 10, 2023
@Ho-Ro
Copy link

Ho-Ro commented Jan 10, 2023

Thx, stupid me, I couldn't see the forest for the trees :)

@KangLin
Copy link

KangLin commented Feb 9, 2023

Any progress?

oblivioncth added a commit to oblivioncth/Stexatlaser that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/StartFP that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/CLIFp that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/FIL that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/libfp that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/QI-QMP that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/Qx that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
oblivioncth added a commit to oblivioncth/STARpp that referenced this issue Feb 10, 2023
softprops/action-gh-release globing doesn't support backslashes as
directory separators and instead always treats them as the an escape
character when a glob-based input under 'files' is detected.

Because of this, have the release job run on ubuntu so that the
zip artifact directory path environment variable declared at the
workflow level will resolve to a path with forward slashes, since
environment variables are only evaluated at the job level.

See: softprops/action-gh-release#280
KisaragiEffective added a commit to KisaragiEffective/DoNotIncludeDefaultResourceForSize that referenced this issue Feb 28, 2023
ekoby added a commit to openziti/ziti-sdk-c that referenced this issue Mar 13, 2023
fredemmott added a commit to fredemmott/action-gh-release that referenced this issue Mar 25, 2023
softprops#280

Document change in glob 8.0
softprops pushed a commit that referenced this issue Mar 26, 2023
* Add note about windows paths

#280

Document change in glob 8.0

* Fix incorrectly escaped markdown backslashes
Trolldemorted added a commit to P3Modding/P3Manager that referenced this issue Sep 23, 2023
Fallen-Breath added a commit to Fallen-Breath/PCRC that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants