Convert "pure" macros to pure fn in config.rs
#10893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These macros simply took a `Span` and a shared reference to `Config` and returned a Value, for better readability and reasoning about their behavior convert them to simple function as they don't do anything relevant with their macro powers.
|
Been wanting to do this for a while now. thanks! |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description These macros simply took a `Span` and a shared reference to `Config` and returned a Value, for better readability and reasoning about their behavior convert them to simple function as they don't do anything relevant with their macro powers. # User-Facing Changes None # Tests + Formatting (-)
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description These macros simply took a `Span` and a shared reference to `Config` and returned a Value, for better readability and reasoning about their behavior convert them to simple function as they don't do anything relevant with their macro powers. # User-Facing Changes None # Tests + Formatting (-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These macros simply took a
Spanand a shared reference toConfigandreturned a Value, for better readability and reasoning about their
behavior convert them to simple function as they don't do anything
relevant with their macro powers.
User-Facing Changes
None
Tests + Formatting
(-)