-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove file I/O from tests that don't need it #11182
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
062a55f
Update uniq tests to avoid file usage
cosineblast d4c89f6
Remove file I/O from merge tests
cosineblast ccae827
Remove file I/O from compact command tests
cosineblast c2a431b
Remove file I/O from move command tests
cosineblast 99e0133
Remove file I/O from take while command tests
cosineblast 8e5bccd
Remove file I/O from histogram command tests
cosineblast 646aeae
Remove file I/O from take until command tests
cosineblast b67bf86
Remove file I/O from skip while command tests
cosineblast 5e03adb
Remove file I/O from skip until command tests
cosineblast 502120b
Remove file I/O from take rows tests
cosineblast af27556
Remove file I/O from flatten, sum and select tests
cosineblast 28a133b
Remove unecessary file I/O from multiple tests
cosineblast fa4d87a
Fix style and test issues
cosineblast 052d57e
Apply clippy 'static lifetime suggestions
cosineblast 2a87c35
Use {variable} formatting in tests
cosineblast 4af1ec0
Revert some I/O modifications to pipeline tests
cosineblast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's wrongly formatted, would you please run
cargo fmt
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, that's a bit weird, but I did run cargo fmt:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let ... = ... else {}
formatting was only stabilized in very recent versions ofrustfmt
and may possibly still be treated preserved depending on the active toolchain version?