Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LSP Server Release #11250

Closed

Conversation

schrieveslaach
Copy link
Contributor

Modifications made to lsp-server crate haven't been released yet. Thus, the git dependency has been replaced by the current release version and the changes reverted that allow to exit the LSP server during initialization. The code that shall be reenabled is still available as a comment in the source.

Modifications made to lsp-server crate haven't been released yet. Thus,
the git dependency has been replaced by the current release version and
the changes reverted that allow to exit the LSP server during
initialization. The code that shall be reenabled is still available as a
comment in the source.
@AucaCoyan
Copy link
Contributor

AucaCoyan commented Dec 6, 2023

Yup, I can provide the link to the rust-analyzer PR for reference

I've been following your work and it is amazing @schrieveslaach !
I hope I can keep up with the progress 🚀

@fdncred
Copy link
Collaborator

fdncred commented Dec 6, 2023

Is it not included in this release? https://github.com/rust-lang/rust-analyzer/releases/tag/2023-12-04?

@AucaCoyan
Copy link
Contributor

AucaCoyan commented Dec 6, 2023

Yeah, I fell for that too, it is included in 2023-11-27, a couple of days earlier

@fdncred
Copy link
Collaborator

fdncred commented Dec 6, 2023

oh, cool, but has it been published to crates.io?

@AucaCoyan
Copy link
Contributor

Oh, I dont know. I've just checked and I believe so, yes
https://crates.io/crates/lsp-server
says
lsp-server = "0.7.4"
and its package Cargo.toml also says
version = "0.7.4"

Is that 100% released? I don't know rust that deeply enough 🤣

@schrieveslaach
Copy link
Contributor Author

It has been released a few minutes ago. I'll create a new PR.

@schrieveslaach
Copy link
Contributor Author

see #11252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants