Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelable Initialization #15894

Merged
merged 1 commit into from Nov 22, 2023
Merged

Cancelable Initialization #15894

merged 1 commit into from Nov 22, 2023

Conversation

schrieveslaach
Copy link
Contributor

This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling.

In the process of adding LSP to Nushell (see nushell/nushell#10941) this gap has been identified.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2023
@schrieveslaach schrieveslaach mentioned this pull request Nov 14, 2023
Merged
@Veykril
Copy link
Member

Veykril commented Nov 21, 2023

Seems fine to add for now, though long term we should consider what matklad wrote here #14582 (comment)
@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2023

📌 Commit f95d538 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 21, 2023

⌛ Testing commit f95d538 with merge be34563...

bors added a commit that referenced this pull request Nov 21, 2023
@bors
Auto merge of #15894 - schrieveslaach:cancelable-initialization, r=Ve…
be34563 
…ykril

Cancelable Initialization

This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling.

In the process of adding LSP to Nushell (see nushell/nushell#10941) this gap has been identified.
@bors
Copy link
Collaborator

bors commented Nov 21, 2023

💔 Test failed - checks-actions

@Veykril
Copy link
Member

Veykril commented Nov 21, 2023

Looks like this needs a rebase + Cargo.lock update

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2023
@schrieveslaach
Cancelable Initialization
81c2d35 
This commit provides additional initialization methods to Connection in
order to support CTRL + C sigterm handling.
@schrieveslaach
Copy link
Contributor Author

@Veykril, I rebased this branch. Please, check it out again.

@Veykril
Copy link
Member

Veykril commented Nov 22, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

📌 Commit 81c2d35 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

⌛ Testing commit 81c2d35 with merge 7ceefc7...

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7ceefc7 to master...

@bors bors merged commit 7ceefc7 into rust-lang:master Nov 22, 2023
10 checks passed
@schrieveslaach
Copy link
Contributor Author

@Veykril, are you planning a release of this crate in the near future? @fdncred would love to get rid of a branch dependency in Nushell (which I can understand).

@schrieveslaach
Copy link
Contributor Author

And thank you very much for accepting this PR.

@Veykril
Copy link
Member

Veykril commented Nov 23, 2023

Ye, we can cut a release for this. Given the changes a patch release should be fine (since we are below 1.0 with the lib still). Though I'm a bit busy right now

@sholderbach sholderbach mentioned this pull request Nov 29, 2023
Closed
@AucaCoyan AucaCoyan mentioned this pull request Dec 6, 2023
Closed
@fdncred
Copy link

fdncred commented Dec 6, 2023 •
edited

@Veykril We were hoping this would be in the next release, but I guess it missed it (unless i'm reading something wrong). We have a nushell release on Dec 12th, is there any hope of a release that includes this change before then? If not, we'll need to rollback some changes. Thanks for your help!

It was brought to my attention that it has been released here https://github.com/rust-lang/rust-analyzer/releases/tag/2023-11-27. yay! It just doesn't look like lsp-server has been published to crates.io yet. Is that possible?

@Veykril
Copy link
Member

Veykril commented Dec 6, 2023

Oh sorry, I completely forgot to push the release for this, 0.7.5 should be out now

@schrieveslaach
Copy link
Contributor Author

@Veykril, thank you very much for the release. I'll go ahead and update the Nushell dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@schrieveslaach @Veykril @bors @fdncred @rustbot