Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 228 json html themes for to html #2308

Merged
merged 4 commits into from
Aug 10, 2020
Merged

Add 228 json html themes for to html #2308

merged 4 commits into from
Aug 10, 2020

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Aug 6, 2020

pretty big change here

  • removed old assets, added new zipped asset
  • added --list to get a list of the theme names
  • reworked some older theme code
  • added rust-embed and zip crate
  • removed the dark tests

removed old assets, added new zipped asset
added --list to get a list of the theme names
reworked some older theme code
added rust-embed and zip crate
removed the dark tests
@fdncred fdncred requested a review from sophiajt August 7, 2020 00:36
Copy link
Contributor

@sophiajt sophiajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Just a couple nits

crates/nu-cli/src/commands/to_html.rs Outdated Show resolved Hide resolved
crates/nu-cli/src/commands/to_html.rs Outdated Show resolved Hide resolved
Changed usage a bit
Updated the error handling
Added some helper items in --list
@sophiajt
Copy link
Contributor

Looks good

@sophiajt sophiajt merged commit f0dbffd into nushell:main Aug 10, 2020
@fdncred fdncred deleted the add_asset_themes_for_to_html branch August 23, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants