Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let a simple last be a single value #5060

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Apr 1, 2022

Description

before:

> [1, 2, 3] | last
[3]

now:

> [1, 2, 3] | last
3

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@sophiajt sophiajt merged commit 4bb95a8 into nushell:main Apr 1, 2022
@sophiajt sophiajt deleted the better_last branch April 1, 2022 10:12
@fdncred
Copy link
Collaborator

fdncred commented Apr 1, 2022

This broke my prompt but I like this change. Good job! A real quality-of-life improvement. I really dislike having to do | get 0 or $blah.0. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants