Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str casings reorganization & description updates #5572

Merged
merged 1 commit into from
May 18, 2022
Merged

Str casings reorganization & description updates #5572

merged 1 commit into from
May 18, 2022

Conversation

krober
Copy link
Contributor

@krober krober commented May 18, 2022

Description

nu-command/src/strings/str_

  • Move capitalize, downcase, and upcase to /case
  • Fix example descriptions
  • Clarify/shorten a couple usage strings

Tests

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@rgwood rgwood merged commit 3e09158 into nushell:main May 18, 2022
@rgwood
Copy link
Contributor

rgwood commented May 18, 2022

Nice, thanks for fixing that up!

@krober krober deleted the casing branch May 18, 2022 13:28
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
…tions; clarify usage text (nushell#5572)

Co-authored-by: kyle <kyle@archtop.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants