enable find to be able to highlight some hits #6086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables the
find
command to be able to highlight hits in certain circumstances. Everything should work the same as it used to with the exception ofls | find term1 term2 term3
should now be highlighted with white on red.There are some corner cases that this find change and the original help highlighting change fail on.
TODOS - up for grabs
find
doesn't highlight on anything but tables as in the example. please feel free to contribute highlighting on strings and lists.help -f
andfind
to use a custom_highlight_color instead of always using white on redThis PR also contains a small refactor to LS_COLORS so we don't have to copy that default LS_COLORS env var string around everywhere.
Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code stylecargo test --workspace --features=extra
to check that all the tests pass