Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mv multiple files at once #6103

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Conversation

PlasmaIntec
Copy link
Contributor

Description

#6102

Turn the required "source" argument into a rest "source(s)" argument, then iterate across sources using .flat_map().

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

@sam701
Copy link

sam701 commented Jul 23, 2022

@PlasmaIntec Don't you mind to change the cp behavior, as well, to keep them consistent? It would be great if mv and cp have the same "signature".

@fdncred
Copy link
Collaborator

fdncred commented Jul 23, 2022

thanks

@fdncred fdncred merged commit 7d46177 into nushell:main Jul 23, 2022
@PlasmaIntec PlasmaIntec mentioned this pull request Jul 24, 2022
6 tasks
@PlasmaIntec PlasmaIntec deleted the mv_multiple branch July 26, 2022 05:56
@nibon7 nibon7 mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants