Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print_table_or_error when table is overridden #6130

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fix print_table_or_error when table is overridden #6130

merged 1 commit into from
Jul 26, 2022

Conversation

nibon7
Copy link
Contributor

@nibon7 nibon7 commented Jul 26, 2022

Description

Similar to #6113, when run command from string, the same error occurs.

nu -c "def table [] { \"hi\" }; table"

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

Related #6113

Signed-off-by: nibon7 <nibon7@163.com>
@fdncred
Copy link
Collaborator

fdncred commented Jul 26, 2022

thanks

@fdncred fdncred merged commit 86a0e77 into nushell:main Jul 26, 2022
@nibon7 nibon7 deleted the table_override branch July 26, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants