Type validation for headers command (#6918)
#7047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think this makes sense. Could you please add some tests? I think you could convert some of your "Commands with error" examples into tests that expect an error. |
raccmonteiro
force-pushed
the
headers-type-validation
branch
from
10cdf76
to
af89f74
Compare
cargo clippy lints tests format
raccmonteiro
force-pushed
the
headers-type-validation
branch
from
af89f74
to
0aad7d3
Compare
|
@rgwood I added some tests like you suggested. |
raccmonteiro
changed the title
headers command (#6918)
|
Thank you - LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type validation for headers command. We are only allowed to view the following types in headers: Null, String, Bool, Float, Int. Any other type different than these ones will result in an error like the image below.
New error message: "needs compatible type: Null, String, Bool, Float, Int"
Fixes #6918
Tests + Formatting
Commands with error:
[[a b]; [1 ($nu.scope.modules)] [2 2]] | headers[[a b]; [{}, 2], [3,4] ] | headers[[a b]; [[f,g], 2], [3,4] ] | headersValid commands:
"a b c|1 2 3" | split row "|" | split column " " | headers[[a b]; [false, 2], [3,4] ] | headers[[a b]; [1, 2], [3,4] ] | headers[[a b]; [null, 2], [3,4] ] | headersUser-Facing Changes
No major change.