Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser refactoring for improving pipelines #7162

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

sophiajt
Copy link
Contributor

Description

This is a batch of parser refactors for moving away from pipelines that assume things are always piped to being able to handle more bash-isms in the pipelines.

This PR does not add additional functionality, but instead makes adding that functionality in the future easier. I've put in a few potential cases for pipeline elements we might want, though this list may change as we decide which bashisms we want.

User-Facing Changes

None yet.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@sophiajt sophiajt merged commit 6454bf6 into nushell:main Nov 18, 2022
@sophiajt sophiajt deleted the parser_refactoring branch November 18, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant