Ansi link #7751
Ansi link #7751
Conversation
|
Just a question. I'm wondering if it's more nushelly to make this |
|
Changed it to work the same way as
|
| (Type::Record(vec![]), Type::Record(vec![])), | ||
| ]) | ||
| .named( | ||
| "text", |
There was a problem hiding this comment.
| "text", | |
| "title", |
It just seems to me that --title is the better name for this parameter than --text. What do you think?
There was a problem hiding this comment.
I don't think so. For example in HTML title attribute has meaning of tooltip. For example:
<a href="https://nushell.sh" title="A new type of shell">Nushell</a>generates
I think naming parameter titile may be confusing
There was a problem hiding this comment.
That's the point I'm making. In your html example, the title is "A new type of shell" so the link shows "A new type of shell" instead of showing "https://nushell.sh". That's why I'm suggesting it.
There was a problem hiding this comment.
Exactly. But the --text flag controls text of link, not tooltip. This is a call equivalent to my html example:
And as far as i understand there is no way to alter tooltip. In my screenshot it is generated by windows terminal and just shows what content of link is hidden
There was a problem hiding this comment.
I know of no way to control the tooltip either, but I wasn't talking about the tool tip. I prefer title but I'm not going to die on this hill. It's not that big of a deal. I'll let someone else accept or deny this PR.
|
I really like this and thanks for making those changes. It definitely feels more like nushell now. |
Description
Add
ansi linkcommand that adds special ansi escape sequence to create a link in terminal:This command accepts two arguments: uri of link and optional link text. If second parameter is not present link is displayed as is:
More info on links in terminals https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
User-Facing Changes
New
ansi linkcommandTests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.