Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify the run functions of all and any #8578

Merged
merged 1 commit into from
Mar 23, 2023
Merged

unify the run functions of all and any #8578

merged 1 commit into from
Mar 23, 2023

Conversation

1Kinoti
Copy link
Contributor

@1Kinoti 1Kinoti commented Mar 23, 2023

Description

this pr reduces duplication by making any and all commands use one function

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #8578 (efe0345) into main (66ad83c) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8578      +/-   ##
==========================================
+ Coverage   68.14%   68.50%   +0.36%     
==========================================
  Files         624      624              
  Lines      100670   100654      -16     
==========================================
+ Hits        68601    68958     +357     
+ Misses      32069    31696     -373     
Impacted Files Coverage Δ
crates/nu-command/src/filters/all.rs 100.00% <100.00%> (ø)
crates/nu-command/src/filters/any.rs 100.00% <100.00%> (ø)
crates/nu-command/src/filters/utils.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks! Awesome to see full coverage on that one. (the empty list base case is also unchanged)

@sholderbach sholderbach merged commit 403bf1a into nushell:main Mar 23, 2023
@1Kinoti 1Kinoti deleted the boolean-fold branch March 24, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants