Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent redefining fields in a record #8705

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Apr 1, 2023

Description

Prevents redefining fields in a record, for example {a: 1, a: 2} would now error.

fixes #8699

User-Facing Changes

Is technically a breaking change. If you relied on this behaviour to give you the last value, your code will now error.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass
  • cargo run -- crates/nu-utils/standard_library/tests.nu to run the tests for the standard library

Note
from nushell you can also use the toolkit as follows

use toolkit.nu  # or use an `env_change` hook to activate it automatically
toolkit check pr

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@sophiajt sophiajt added the pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes label Apr 1, 2023
@sophiajt sophiajt merged commit 1817d5e into nushell:main Apr 1, 2023
@sophiajt sophiajt deleted the no_redefine_fields branch April 1, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the same field twice in a record should not silently overwrite previous value
1 participant